add destroyed flag and yield ctx.abort#26558
Merged
Merged
Conversation
Updates documentation to reflect that destroy() can now be safely called within scheduled task callbacks. The Agent properly handles cleanup by: - Setting an internal flag to skip remaining database updates - Yielding ctx.abort() to the event loop for clean alarm handler completion This addresses the fix in cloudflare/agents#653 where calling destroy() inside a schedule previously caused errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
threepointone
requested review from
elithrar,
irvinebroque,
rita3ko and
thomasgauvin
as code owners
November 17, 2025 10:54
github-actions
Bot
added
product:agents
Updates documentation to reflect that destroy() can now be safely called from within scheduled task callbacks. The Agent SDK now: - Sets an internal flag to prevent database updates after destruction - Defers ctx.abort() to the event loop to allow handlers to complete Related to cloudflare/agents#653 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Updates schedule-tasks.mdx to reflect changes from cloudflare/agents#653: - Add example showing immediate task scheduling (delay = 0) - Document safe usage of destroy() within scheduled callbacks - Explain that Agent SDK defers destruction to ensure scheduled tasks complete Addresses the fix for issue #616 where calling destroy() inside a schedule would cause errors and retry loops. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Updated documentation to include:
These changes reflect the fixes from cloudflare/agents#653 for issue #616. |
Contributor
irvinebroque
approved these changes
Nov 17, 2025
Contributor
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label is helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$PR_BODY_TEXT